Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basePath is not being honored for static assets, e.g. CSS and Images #652

Closed
2 tasks done
stormmore opened this issue Sep 25, 2023 · 8 comments
Closed
2 tasks done
Assignees
Labels
bug Something isn't working stale Marked as stale by stalebot triage This bug needs triage

Comments

@stormmore
Copy link

What happened?

setting the base path doesn't change the href for images and css

What did you expect to happen?

images and css to be downloaded and rendered

How can we reproduce this?

setg basePath

Version

4.10.0

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project's Code of Conduct

Additional context

No response

@stormmore stormmore added bug Something isn't working triage This bug needs triage labels Sep 25, 2023
@transient1 transient1 self-assigned this Sep 25, 2023
@sudermanjr
Copy link
Member

Stevie was able to reproduce this. We'll take a look

@github-actions github-actions bot added the stale Marked as stale by stalebot label Nov 26, 2023
@karimarous
Copy link

Hello, just curious to know when this bug will be fixed?

@github-actions github-actions bot removed the stale Marked as stale by stalebot label Dec 2, 2023
@github-actions github-actions bot added the stale Marked as stale by stalebot label Feb 1, 2024
@github-actions github-actions bot closed this as completed Feb 9, 2024
@sudermanjr sudermanjr removed the stale Marked as stale by stalebot label Feb 13, 2024
@sudermanjr sudermanjr reopened this Feb 13, 2024
@ericksoncl23
Copy link

I'm having the same problem.
Doesn't work 404- https:///goldilocks
I get this page but all images and css is broken - https:///goldilocks/namespaces

The images do exist under /goldilocks/static/images/goldilocks.svg
However the dashboard page is only linking to /static/images/goldilocks.svg

@karimarous
Copy link

Still facing the same issue. I'm using the latest helm version 8.0.1

@BzSpi
Copy link

BzSpi commented Feb 29, 2024

Is there any previous version that works waiting for the fix ?

This is due to the trailing slash that is missing in base href but can't find where it's done.

edit: it works with image 4.9.0 with latest helm chart

@julian-vp
Copy link

julian-vp commented Mar 4, 2024

As a workaround one can use custom Ingress with a similar configuration:

apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  annotations:
    nginx.ingress.kubernetes.io/rewrite-target: /goldilocks/static/$1/$2
    nginx.ingress.kubernetes.io/use-regex: 'true'
  name: fairwinds-goldilocks-static
spec:
  rules:
    - host: your.host
      http:
        paths:
          - backend:
              service:
                name: fairwinds-goldilocks-dashboard
                port:
                  name: http
            path: /static/(css|images|js|webfonts)/(.*)$
            pathType: ImplementationSpecific
...

@dlahn
Copy link

dlahn commented Mar 18, 2024

Confirmed this works in 4.9.0 image with latest helm chart. Are there any plans to fix this?

@github-actions github-actions bot added the stale Marked as stale by stalebot label May 18, 2024
@BzSpi
Copy link

BzSpi commented May 27, 2024

Please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale Marked as stale by stalebot triage This bug needs triage
Projects
None yet
Development

No branches or pull requests

8 participants