Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landscape Mode #8

Open
SynMaki opened this issue Sep 5, 2023 · 5 comments
Open

Landscape Mode #8

SynMaki opened this issue Sep 5, 2023 · 5 comments

Comments

@SynMaki
Copy link

SynMaki commented Sep 5, 2023

Hey, Is there any change to get a Mode for Horizontal Screens which will place the Lyrics in the whole middle section?

I have some modules to the left and right, but nothing in the middle. Therefore it would be nice to have the Lyrics in the complete middle section (from top to bottom) since it will not overlap the oder modules on the side.

Also, a hideStrategy when no lyrics are found would be awesome :)

Thank you!

@Fabrizz
Copy link
Owner

Fabrizz commented Sep 6, 2023

Hey, can you send a screenshot so I can view better what you mean?
Maybe a mode were you just put the horizontal px and centers it to a vertical lyrics "socket", as making it change automatically maybe difficult to do

Originally I had a hideStrategy for no-lyrics, but it was difficult to take into account refresh times, genius scrapping time, user defined polling time in mmm-onsp, etc

@SynMaki
Copy link
Author

SynMaki commented Sep 6, 2023

Sure, thats how i tought:
MM

ah gotcha, so unfortunately no solution for that atm.
Thanks!

@Fabrizz
Copy link
Owner

Fabrizz commented Sep 6, 2023

That would look good, when I get some free time Im going to do it, abt the other thing if I remember correctly there is a class pair that is applied only on no lyrics or connection error, you could just use display: none or opacity: 0 in the CSS

@SynMaki
Copy link
Author

SynMaki commented Sep 6, 2023

Thats awesome!
Thank you so much!
i will also try te CSS configuration, thanks for your Input!

@Fabrizz
Copy link
Owner

Fabrizz commented Sep 12, 2023

Hey @SynMaki it actually simpler than I though, just use lyricsFillType: "container" and add this to your css/custom.css:

  :root {
      --LILY-SYNMAKI-LR-PADDING: 480px; /* <-- Change here to match your display */
  
      /* Overrides default gap calc sizes from MM2 (only on module) */
      --LILY-VIEW-MARGIN-L: var(--LILY-SYNMAKI-LR-PADDING) !important;
      --LILY-VIEW-MARGIN-R: var(--LILY-SYNMAKI-LR-PADDING) !important;
  }

This allows you to manually override the LR spacing, as the module uses calc() to do the math for everything else

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants