Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Modify agentx to be allowed to be called #15980

Merged
merged 1 commit into from
May 20, 2024

Conversation

donaldsharp
Copy link
Member

If you had a situation where an operator turned on ospfd with snmp but not ospf6d and agentx was configured then you get into a situation where ospf6d would complain that the config for agentx did not exist. Let's modify the code to allow this situation to happen.

Fixes: #15896

@ton31337
Copy link
Member

ton31337 commented May 9, 2024

@Mergifyio backport stable/10.0

Copy link

mergify bot commented May 9, 2024

backport stable/10.0

✅ Backports have been created

@eqvinox eqvinox self-requested a review May 9, 2024 16:15
@eqvinox
Copy link
Contributor

eqvinox commented May 9, 2024

I think this can be done better in vtysh; I'll try doing that & open a PR — if there's nothing in a few days I have clearly failed and this can proceed 😆

If you had a situation where an operator turned on
ospfd with snmp but not ospf6d and agentx was configured
then you get into a situation where ospf6d would complain
that the config for agentx did not exist.  Let's modify
the code to allow this situation to happen.

Fixes: FRRouting#15896
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
@ton31337
Copy link
Member

A few days passed, does it mean clearly failed? 😄

@ton31337 ton31337 merged commit b87d5a4 into FRRouting:master May 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

frrinit.sh - OSPF6 Unknown command: agentx
3 participants