[Bug] Failure in processing cancellation/deletion of product/service

[conffi]

Describe the bug

Summary: Failure in processing cancellation/deletion of product/service

How to reproduce

Context:
If a customer requests the cancellation of a hosting service/account through the customer panel, the administrator receives an open ticket with the request. The administrator accesses the order, clicks on "cancel or delete," and the system enters an infinite processing state, never reaching a conclusion; it always stays in the loading processing state. However, in DirectAdmin, the account is deleted, but in the system, this deletion does not occur, neither for the administrator nor for the customer. The service remains active for both the administrator and the customer.

Expected behavior

The ideal operating scenario:
When clicking on "cancel":
1 - Cancel open invoices.
2 - Change the status of the order/service to "canceled."
3 - Include canceled orders in the list of cronjobs to execute removal at a specified period.
3.1 - This prevents accidental deletion of a service, requiring cancellation first.
4 - When executing the cronjob for canceled orders, the service is removed from both the system and the server/DirectAdmin.
5 - Display the callback message on the screen in a popup or modal.

When clicking on "delete":
1 - Check if the order is canceled.
1.1 - If the order is active, the system informs that cancellation is necessary first.
1.2 - An order should not be deleted without being canceled to avoid accidental deletions.
2 - Delete the server on both the server and the system.
3 - Display the callback message on the screen in a popup or modal.

Screenshots

No response

FOSSBilling version

0.6.15

FOSSBilling instance ID

No response

Module version

No response

Device

No response

Information

No response

Additional context

No response

[BelleNottelling]

Sorry for the delayed response to this, other items have been keeping my attention.

Looks like there's a couple of items you've put here.

3 - Include canceled orders in the list of cronjobs to execute removal at a specified period.

I'm not sure about doing this, these actions shouldn't take that long to execute and if we doing it when the users clicks the button then we can give instant feedback on if it worked or not. If there's a problem where they are doing this accidentally, then I'd argue it's a UI issue and we should ensure there's a verification prompt.

For the specific issue you've described where it went into an indefinite loading state, I'd have to see the associated error log before I have any idea on what happened.
However, this has reminded me that it's possible for the two systems to get out of sync and then be stuck getting errors inside of FOSSBilling when you attempt to delete something. I think a reasonable solution is to add to the delete modal a "force delete" checkbox which causes FOSSBilling to remove the item from it's end, regardless of if any "errors" occur downstream

[conffi]

Obrigado pelo seu retorno e sugestões. Hoje eu vi que já tem uma atualização, vou ver como ficou o funcionamento geral. Estou me organizando para tentar contribuir com alguma coisa neste projeto. Att André Garcia

…

________________________________ De: Belle Aerni ***@***.***> Enviado: domingo, 24 de março de 2024 17:24 Para: FOSSBilling/FOSSBilling ***@***.***> Cc: conffi ***@***.***>; Author ***@***.***> Assunto: Re: [FOSSBilling/FOSSBilling] [Bug] Failure in processing cancellation/deletion of product/service (Issue #2161) Sorry for the delayed response to this, other items have been keeping my attention. Looks like there's a couple of items you've put here. 3 - Include canceled orders in the list of cronjobs to execute removal at a specified period. I'm not sure about doing this, these actions shouldn't take that long to execute and if we doing it when the users clicks the button then we can give instant feedback on if it worked or not. If there's a problem where they are doing this accidentally, then I'd argue it's a UI issue and we should ensure there's a verification prompt. For the specific issue you've described where it went into an indefinite loading state, I'd have to see the associated error log before I have any idea on what happened. However, this has reminded me that it's possible for the two systems to get out of sync and then be stuck getting errors inside of FOSSBilling when you attempt to delete something. I think a reasonable solution is to add to the delete modal a "force delete" checkbox which causes FOSSBilling to remove the item from it's end, regardless of if any "errors" occur downstream — Reply to this email directly, view it on GitHub<#2161 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHE2MZU2IHRVV2YBMAA3A3YZ477JAVCNFSM6AAAAABDTRAE3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJWHE2DONRSGI>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[jaapmarcus]

Please use English

[conffi]

Thanks for the return, I also saw in the change logs that you added a fix for what I mentioned, this shows that you are really committed. Fantastic. I will try to collaborate by creating a more modern version for the client area Att André Garcia

…

________________________________ De: Jaap Marcus ***@***.***> Enviado: segunda-feira, 25 de março de 2024 10:17 Para: FOSSBilling/FOSSBilling ***@***.***> Cc: conffi ***@***.***>; Author ***@***.***> Assunto: Re: [FOSSBilling/FOSSBilling] [Bug] Failure in processing cancellation/deletion of product/service (Issue #2161) Please use English — Reply to this email directly, view it on GitHub<#2161 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHE2MYVBU4HWFFWBY6XT4TY2AWYHAVCNFSM6AAAAABDTRAE3CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJYGEYDQNZZGM>. You are receiving this because you authored the thread.Message ID: ***@***.***>