New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDK doctor --fix --all points the origin of integration instances to moodle.git after running mdk run setupsecurity #164

Open

junpataleta opened this issue Dec 18, 2017 · 1 comment

Collaborator

junpataleta commented Dec 18, 2017 •

edited

To reproduce:

Create and install an integration instance.
Run mdk run setupsecurity
Run mdk doctor --fix --all
Run git remote -vv
- Origin now points to ~/.moodle-sdk/moodle.git

The text was updated successfully, but these errors were encountered:

Contributor

dmonllao commented Dec 19, 2017

Hi Jun, we don't flag the instance as a security instance just add a hook and use security.git as origin. I don't know much about mdk but a possible solution would be to respect that origin can be set to mdk config show remotes.security in https://github.com/FMCorz/mdk/blob/master/mdk/commands/doctor.py#L222 and https://github.com/FMCorz/mdk/blob/master/mdk/commands/doctor.py#L228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment