Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TUI shows "Ready" even though the process has aborted #157

Open
teto opened this issue Mar 8, 2024 · 0 comments
Open

TUI shows "Ready" even though the process has aborted #157

teto opened this issue Mar 8, 2024 · 0 comments

Comments

@teto
Copy link

teto commented Mar 8, 2024

I have my redis service who failed to start because I had already a running instance on my machine.
The readiness probe is configured with

    readiness_probe:
      exec:
        command:
          redis-cli ping

and I found it weird that it showed me the service as "Ready" even though the process failed
image

I think it does because the probe actually succeeds but it's weird to mark the process "Ready" and at the same time "Completed".

In terms of UX, I think we can do better than showing "Completed" when the exit status != 0 to convey the idea of an error though I am not sure what.
"Failed" is ambiguous, aka it doesn't say if the process ever started.
Completed with error might be long.

I wonder if it's worth to have a column per exit code. I suppose it's done to sort them out ? One way could be to show the exit code next to the "Completed" otherwise, e.g., Completed (1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant