Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check consistency when merging sequences #1694

Open
jan-petr opened this issue Apr 22, 2024 · 0 comments · May be fixed by #1709
Open

Check consistency when merging sequences #1694

jan-petr opened this issue Apr 22, 2024 · 0 comments · May be fixed by #1709
Assignees
@jan-petr
Labels
feature New feature, enhancement or request
Milestone
Release 1.12.0

Comments

@jan-petr
Copy link
Contributor

jan-petr commented Apr 22, 2024 •
edited

Description

We now save extra tags in PWI4D.json - Manufacturer, MagneticFieldStrength, PulseSequenceType, MRAcquisitionType, ArterialSpinLabelingType, Background suppression.
When merging two PWI4D.json, we have to check that these fields are consistent and then report an error if they are not.

Release notes

Nothing. Report with #997
@jan-petr jan-petr added the feature New feature, enhancement or request label Apr 22, 2024
@jan-petr jan-petr added this to the Release 1.12.0 milestone Apr 22, 2024
@jan-petr jan-petr self-assigned this Apr 22, 2024
jan-petr added a commit that referenced this issue May 19, 2024
@jan-petr
#1694 Check merging consistency in JSON
5d59d09
@jan-petr jan-petr linked a pull request May 19, 2024 that will close this issue
Open
@jan-petr jan-petr linked a pull request May 19, 2024 that will close this issue
#1694 Check merging consistency in JSON #1709
Open
jan-petr added a commit that referenced this issue May 22, 2024
@jan-petr
#1694 im_MergePWI4D Check existing/non-existing merge conflict
0063ad1
jan-petr added a commit that referenced this issue May 23, 2024
@jan-petr
#1694 im_MergePWI4D improve warnings and shorten code
503e5f9
jan-petr added a commit that referenced this issue May 23, 2024
@jan-petr
#1694 im_MergePWI4D Improve warnings
afbe136
jan-petr added a commit that referenced this issue May 24, 2024
@jan-petr
#1694 im_MergePWI4D horizontal vectors
8b1a847
HenkMutsaerts added a commit that referenced this issue May 25, 2024
@HenkMutsaerts
#1694 xASL_im_MergePWI4D: simplification & explanation
d9f8ecd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jan-petr jan-petr

Labels
feature New feature, enhancement or request
Projects
None yet
Milestone
Release 1.12.0
Development

Successfully merging a pull request may close this issue.

#1694 Check merging consistency in JSON ExploreASL/ExploreASL
1 participant
@jan-petr