Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

999 lock file always created? #1693

Open
4 tasks
HenkMutsaerts opened this issue Apr 22, 2024 · 0 comments
Open
4 tasks

999 lock file always created? #1693

HenkMutsaerts opened this issue Apr 22, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@HenkMutsaerts
Copy link
Member

Description

It seems that the 999 lock file is not really used anymore. I'm not sure, but this seemed at least the case for the import module. E.g., when you only run 001_dcm2nii, it also creates 999 at the end of the import module (skipping 002). Then what is the point of 999?

The original function of 999 is that you can skip all submodule checks, by only checking 999 at the start of each module. But the ability to only run submodules (i.e. the case for the import module) somehow makes this a moot point.

Tasks

  • Equalize modules: either within modules you cannot choose steps (e.g. as with the T1w & ASL modules), or we can choose steps for each module. This would e.g. work like this:

ExploreASL('path', Import [0 0 0], Structural [0 0 0 0 0 0 0 0 (n=9 submodules), ASL [0:n], Population [0:n])

with of course defaulting. This would make some other things easier as well, e.g. the boolean for motion correction would not be required as this would be ASL [1 0 1 1 1 1 1 n]. And the kids don't have to add breakpoints.

  • Only creating 999 if all submodules were run.
  • Skipping a module if 999 exists
  • Running submodule n will remove lock file for submodule n+1 (we have this already)

This should

HENK NEEDS TO CONTINUE HERE

How to test

Optional: insert description about how to test the code changes here

Release notes

Required: summarize the changes for the release notes here

@HenkMutsaerts HenkMutsaerts added the bug Something isn't working label Apr 22, 2024
@HenkMutsaerts HenkMutsaerts added this to the Release 1.12.0 milestone Apr 22, 2024
@HenkMutsaerts HenkMutsaerts self-assigned this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant