Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structural scans don't require a run-alias #1677

Open
2 tasks
jan-petr opened this issue Apr 8, 2024 · 0 comments
Open
2 tasks

Structural scans don't require a run-alias #1677

jan-petr opened this issue Apr 8, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jan-petr
Copy link
Contributor

jan-petr commented Apr 8, 2024

Description

Runs are usually scantype-specific, e.g. mostly T1w & FLAIRs have a single run, and ASL can have multiple runs, e.g. SinglePLD and MultiPLD. For example, we can have directories "T1w-structural", "FLAIR-structural" and "ASL_SinglePLD", "ASL_MultiPLD", where "structural" was manually added. We then have scantypes T1w|FLAIR|ASL and runAliases "structural|SinglePLD|MultiPLD" See the example above. Ideally, we change the source data as least as possible. We probably just want to make a list of sessions per scantype, and sort it that way. So the session tokens are not only ASL_1 ASL_2 but also T1w_1 and FLAIR_1.

Tasks

  • Allow an empty token for session (MultiPLD|SinglePLD|). Then if we detect an empty token, we give session 1 by default.
  • Note that per BIDS, T1w and FLAIR can have sessions as well. We don't use them in ExploreASL processing but for dcm2BIDS they should be detected, so we need the option for 2 FLAIR or T1w sessions (not urgent though). This would be the typical case if a study has repeated a FLAIR when there was motion, and BIDS would then have two FLAIRs, and the user removes the FLAIR with the most motion, whereas the sourcedata should be kept intact (read-only). But this is really complicated and requires a complete rehaul and has to be moved to a new issue

How to test

Optional: insert description about how to test the code changes here

Release notes

Required: summarize the changes for the release notes here

@jan-petr jan-petr added the bug Something isn't working label Apr 8, 2024
@jan-petr jan-petr added this to the Release 1.12.0 milestone Apr 8, 2024
@jan-petr jan-petr self-assigned this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant