You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
T1b should be 1.7306679, T1t should be 1.33 HENK: why? We need reasoning for this. Note that "this is what FME/DEBBIE wants" cannot be the only motivation. JAN All previous DEBBIE code used that so we wanted to have that for checking that the behavior is the same as it was. Jan is fine with keeping 1650 ms and 1240 ms for all. HENK: We should (I think we already have this) have T1b as option, which would solve the comparison issue. As a default T1b: I would argue we use something that has most consensus (e.g., white paper or a newer gray paper). I find it tricky to use what Amnah uses — even if it is better — because ExploreASL should be comparable with other white/gray paper-based pipeline. Ideally, the new gray paper by Joe Woods/Michael already recommends the same values as Amnah uses, then we have a good reason to take this new default. We can of course print this parameter extra with its source, doesn't hurt to make the user aware of the defaults we use and why, especially when there are multiple standards (if a lot of people use the DEBBIE sequence then this also becomes a de facto standard)JAN Lets move this to a new DEBBIE issue.
Tasks
Implement xyz in function xASL_[abc]_...
How to test
Optional: insert description about how to test the code changes here
Release notes
Required: summarize the changes for the release notes here
The text was updated successfully, but these errors were encountered:
Description
T1b should be 1.7306679, T1t should be 1.33 HENK: why? We need reasoning for this. Note that "this is what FME/DEBBIE wants" cannot be the only motivation. JAN All previous DEBBIE code used that so we wanted to have that for checking that the behavior is the same as it was. Jan is fine with keeping 1650 ms and 1240 ms for all. HENK: We should (I think we already have this) have T1b as option, which would solve the comparison issue. As a default T1b: I would argue we use something that has most consensus (e.g., white paper or a newer gray paper). I find it tricky to use what Amnah uses — even if it is better — because ExploreASL should be comparable with other white/gray paper-based pipeline. Ideally, the new gray paper by Joe Woods/Michael already recommends the same values as Amnah uses, then we have a good reason to take this new default. We can of course print this parameter extra with its source, doesn't hurt to make the user aware of the defaults we use and why, especially when there are multiple standards (if a lot of people use the DEBBIE sequence then this also becomes a de facto standard)JAN Lets move this to a new DEBBIE issue.
Tasks
xASL_[abc]_...
How to test
Optional: insert description about how to test the code changes here
Release notes
Required: summarize the changes for the release notes here
The text was updated successfully, but these errors were encountered: