Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix T1 blood in DEBBIE #1663

Open
1 task
jan-petr opened this issue Mar 28, 2024 · 0 comments
Open
1 task

Fix T1 blood in DEBBIE #1663

jan-petr opened this issue Mar 28, 2024 · 0 comments
Assignees
Labels
feature New feature, enhancement or request

Comments

@jan-petr
Copy link
Contributor

Description

T1b should be 1.7306679, T1t should be 1.33 HENK: why? We need reasoning for this. Note that "this is what FME/DEBBIE wants" cannot be the only motivation. JAN All previous DEBBIE code used that so we wanted to have that for checking that the behavior is the same as it was. Jan is fine with keeping 1650 ms and 1240 ms for all. HENK: We should (I think we already have this) have T1b as option, which would solve the comparison issue. As a default T1b: I would argue we use something that has most consensus (e.g., white paper or a newer gray paper). I find it tricky to use what Amnah uses — even if it is better — because ExploreASL should be comparable with other white/gray paper-based pipeline. Ideally, the new gray paper by Joe Woods/Michael already recommends the same values as Amnah uses, then we have a good reason to take this new default. We can of course print this parameter extra with its source, doesn't hurt to make the user aware of the defaults we use and why, especially when there are multiple standards (if a lot of people use the DEBBIE sequence then this also becomes a de facto standard)JAN Lets move this to a new DEBBIE issue.

Tasks

  • Implement xyz in function xASL_[abc]_...

How to test

Optional: insert description about how to test the code changes here

Release notes

Required: summarize the changes for the release notes here

@jan-petr jan-petr added the feature New feature, enhancement or request label Mar 28, 2024
@jan-petr jan-petr added this to the Release 1.13.0 milestone Mar 28, 2024
@jan-petr jan-petr self-assigned this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature, enhancement or request
Projects
None yet
Development

No branches or pull requests

1 participant