Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealing with SD & SNR in xASL_wrp_resample #1662

Open
1 task
jan-petr opened this issue Mar 28, 2024 · 0 comments
Open
1 task

Dealing with SD & SNR in xASL_wrp_resample #1662

jan-petr opened this issue Mar 28, 2024 · 0 comments
Assignees
Labels
feature New feature, enhancement or request

Comments

@jan-petr
Copy link
Contributor

Description

Manage how to deal with SD & SNR currently saved in xASL_wrp_Resample. xASL_wrp_Resample is for:PWI4D that will later be used for quantification (after potential merging/manual adaptations). Other reference images for PVC, visual QC, etc. For this, we want all available SNR we can get, similar to the temporary PWI created in xASL_wrp_RegisterASL. This is why we want to do the same weighting here as we did in xASL_wrp_RegisterASL (probably by a single weighting function). Historically, we created SD, SNR, and other QC stuff in xASL_wrp_Resample. The question is where we keep this, or if we move this to after quantification. Because we probably want this to be AFTER the merging/manual removal right? (please also think about Mervin merging two single-PLD, one at the start and one at the end of the scan protocol, not only think about a single exotic DEBBIE sequence, but think generalized ;) -> So we could move this SD/SNR part to xASL_wrp_VisualQC, that would make most sense to me. I suggest we do this move in this issue, and do the QC improvement later. JAN Agree - should we do this in a new issue then?

Tasks

  • Implement xyz in function xASL_[abc]_...

How to test

Optional: insert description about how to test the code changes here

Release notes

Required: summarize the changes for the release notes here

@jan-petr jan-petr added the feature New feature, enhancement or request label Mar 28, 2024
@jan-petr jan-petr added this to the Release 1.13.0 milestone Mar 28, 2024
@jan-petr jan-petr self-assigned this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature, enhancement or request
Projects
None yet
Development

No branches or pull requests

1 participant