Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xASL_init_CreateParticipantsTSV does not check rawdata #1658

Open
1 of 11 tasks
Tracked by #1675
HenkMutsaerts opened this issue Mar 27, 2024 · 0 comments
Open
1 of 11 tasks
Tracked by #1675

xASL_init_CreateParticipantsTSV does not check rawdata #1658

HenkMutsaerts opened this issue Mar 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@HenkMutsaerts
Copy link
Member

HenkMutsaerts commented Mar 27, 2024

Description

xASL_init_CreateParticipantsTSV does not check rawdata, only the studyroot and derivatives folders.
Just checking @jan-petr if I didn't fix this already in our revamp, otherwise I will fix this now.

Tasks

  • Wait till Master issue revamped subtraction #1551 and PWI4D & session concatenation follow-up #1543 are merged to develop before creating this branch
  • Create capital-insensitive list of datasetRoot, rawdata, derivatives participants.tsv
  • By priority go 1) derivatives (if already existed), 2) rawdata (per BIDS), 3) datasetRoot
  • Generate warnings if it was provided at the wrong location
  • Generate warnings if multiple participants.tsv existed

Deal with participants.tsv conversion from BIDS sub- to legacy sub-_1

  • Add sub- if missing
  • Add ses- if missing in session_id column
  • from participant_id and session_id columns, generate legacy subject-name including visit

Merging

  • Do we want to merge in case of different participants.tsv?
  • xASL_bids_Add2ParticipantsTSV already has some functionality for this, can we reuse this?

PM (pro memoria)

  • We might want to change x.S.SetsID -> x.S.participantsTSV or something, to harmonize those

How to test

Optional: insert description about how to test the code changes here

Release notes

Required: summarize the changes for the release notes here

@HenkMutsaerts HenkMutsaerts added the bug Something isn't working label Mar 27, 2024
@HenkMutsaerts HenkMutsaerts added this to the Release 1.12.0 milestone Mar 27, 2024
@HenkMutsaerts HenkMutsaerts self-assigned this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant