Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 404 errors cleanly #1

Open
mattdesl opened this issue Mar 15, 2016 · 0 comments
Open

Handle 404 errors cleanly #1

mattdesl opened this issue Mar 15, 2016 · 0 comments

Comments

@mattdesl
Copy link
Collaborator

Should determine how to handle the following:

request('foo/bar.json', { json: true }, (err, body) => ...)

It's kind of annoying to wrap everything in a statusCode check but maybe that is necessary to be a general purpose HTTP request client. However, right now the error message is misleading since it leads to JSON parse instead of something more meaningful.

nickpeihl added a commit to nickpeihl/ags-walk that referenced this issue Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant