Buffer errro

[player2]

See Comment
620b90a#r40322848

[mattdesl]

Most likely you need to update Node.js to a newer version. In previous versions of this module, the code was using `new Buffer`, which is a deprecated function and which will be removed in new versions of Node.js. In the latest version of this module, the code is now using `Buffer.from` which is in line with current versions of Node.js.

…

On Thu, Jul 2, 2020 at 1:34 PM player2 ***@***.***> wrote: See Comment 620b90a#r40322848 <620b90a#r40322848> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#8>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKR3A3FFFVDWBPRWOZUMPLRZR5FTANCNFSM4OO3ATSA> .

[stur86]

I have this problem too when running the code in browser. Buffer.from is defined in Node, but not in Chrome [Version 87.0.4280.88 (Official Build) unknown (64-bit)]. This is the newest version, so obviously the issue can't be just brushed aside.

[stur86]

I found out that a very easy fix to this is to use the package buffer: https://github.com/feross/buffer.

All that needs to be done is to add the dependency, and then add the line

const Buffer = require('buffer/').Buffer;

at the very beginning of is_binary.js.