Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create kafka-junit test for KafkaAnomalyDetectorManager #369

Open
williewheeler opened this issue Feb 19, 2019 · 1 comment
Open

Create kafka-junit test for KafkaAnomalyDetectorManager #369

williewheeler opened this issue Feb 19, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@williewheeler
Copy link
Contributor

Currently the unit test is based on Kafka's test-utils package, but kafka-junit provides deeper support as it allows us to set up a mock broker with input/output topics that we can use. Update the existing unit test to use kafka-junit.

@williewheeler williewheeler added enhancement New feature or request good first issue Good for newcomers labels Feb 19, 2019
@williewheeler williewheeler changed the title Create kafka-junit test for KafkaAnomalyDetectorMapper Create kafka-junit test for KafkaAnomalyDetectorManager Feb 19, 2019
@williewheeler
Copy link
Contributor Author

Not so sure we want to do this after all. On a couple occasions I've run into seeming interactions between tests where disabling one kafka-junit test causes another one to fail:

Connection to node 1 could not be established. Broker may not be available.

This could easily be a matter of my inexperience with kafka-junit.

Might make more sense to use the Kafka Streams test framework, which doesn't spin up a broker, and save the broker stuff for integration tests.

https://kafka.apache.org/11/documentation/streams/developer-guide/testing.html

@adriancole Do you have an opinion here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant