Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new health check to replace the one we lost when removing haystack-commons #259

Open
williewheeler opened this issue Nov 5, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@williewheeler
Copy link
Contributor

The way the haystack-commons health check works is that when an uncaught exception occurs in Kafka, the health controller would write to a file indicating that the app is unhealthy, and then the k8s liveness check would see that and fail the health check.

We want something like this, but we need to coordinate it with #253 and #245. Ill-formatted metrics should now cause the health check to fail.

@williewheeler williewheeler added the enhancement New feature or request label Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant