Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove dependency on 'natives #115

Open
MikhailArkhipov opened this issue Apr 17, 2018 · 5 comments
Open

Please remove dependency on 'natives #115

MikhailArkhipov opened this issue Apr 17, 2018 · 5 comments

Comments

@MikhailArkhipov
Copy link

MikhailArkhipov commented Apr 17, 2018

See
https://www.npmjs.com/package/natives
microsoft/vscode#47569

"This module relies on Node.js's internals and will break at some point. Do not use it, and update to graceful-fs@4.x."

@ZJONSSON
Copy link

ZJONSSON commented Apr 18, 2018

Thanks @MikhailArkhipov, I did not find any references to natives in the dependency tree of unzipper. I do see graceful-fs@4.1.11 as one of the dependencies.

For reference: unzipper is an actively managed fork of unzip with full backwards compatibility and advanced features (such as streaming unzip from url and quickly unzipping single files using the end directory) - please let me know if I can help you further with this or if you have any other concerns.

@MikhailArkhipov
Copy link
Author

MikhailArkhipov commented Apr 18, 2018

-- unzip@0.1.11
  -- fstream@0.1.31
    -- graceful-fs@3.0.11
      -- natives@1.1.1

@ZJONSSON
Copy link

ZJONSSON commented Apr 18, 2018

To clarify, my comment was regarding the actively managed fork which is published as unzipper not unzip.
https://www.npmjs.com/package/unzipper
npm install unzipper

@blake-regalia
Copy link

blake-regalia commented May 10, 2018

If unzip is no longer managed, please contact the owners to ask them consider deprecating it as it is causing major headaches for the node.js community when upgrading to v10.x.

$ npm owner ls unzip
evanoxfeld <eoxfeld@gmail.com>
joeferner <joe@fernsroth.com>

@b-m-9
Copy link

b-m-9 commented Apr 26, 2019

  • Version: 12.0.0
fs.js:27
const { Math, Object, Reflect } = primordials;
                                  ^

ReferenceError: primordials is not defined
    at fs.js:27:35
    at req_ (/Users/bdev/Documents/Projects/exchanger-api/node_modules/natives/index.js:143:24)
    at Object.req [as require] (/Users/bdev/Documents/Projects/exchanger-api/node_modules/natives/index.js:55:10)
    at Object.<anonymous> (/Users/bdev/Documents/Projects/exchanger-api/node_modules/unzip/node_modules/graceful-fs/fs.js:1:37)
    at Module._compile (internal/modules/cjs/loader.js:759:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:770:10)
    at Module.load (internal/modules/cjs/loader.js:628:32)
    at Function.Module._load (internal/modules/cjs/loader.js:555:12)
    at Module.require (internal/modules/cjs/loader.js:666:19)
    at require (internal/modules/cjs/helpers.js:16:16)
    at Object.<anonymous> (/Users/bdev/Documents/Projects/exchanger-api/node_modules/unzip/node_modules/graceful-fs/graceful-fs.js:3:27)
    at Module._compile (internal/modules/cjs/loader.js:759:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:770:10)
    at Module.load (internal/modules/cjs/loader.js:628:32)
    at Function.Module._load (internal/modules/cjs/loader.js:555:12)
    at Module.require (internal/modules/cjs/loader.js:666:19)
    at require (internal/modules/cjs/helpers.js:16:16)
    at Object.<anonymous> (/Users/bdev/Documents/Projects/exchanger-api/node_modules/unzip/node_modules/fstream/lib/reader.js:4:10)
    at Module._compile (internal/modules/cjs/loader.js:759:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:770:10)
    at Module.load (internal/modules/cjs/loader.js:628:32)
    at Function.Module._load (internal/modules/cjs/loader.js:555:12)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants