Skip to content
This repository has been archived by the owner on Apr 29, 2022. It is now read-only.

Show the video url in the talk details page. #1099

Open
umgelurgel opened this issue Jul 18, 2019 · 2 comments
Open

Show the video url in the talk details page. #1099

umgelurgel opened this issue Jul 18, 2019 · 2 comments
Assignees
Labels
Projects

Comments

@umgelurgel
Copy link
Contributor

No description provided.

@aramboi aramboi added this to To do in EP2020 Nov 16, 2019
@switowski switowski self-assigned this Feb 5, 2020
@switowski
Copy link
Contributor

I have some questions for clarification:

  1. The most important one - is this feature still needed (seems like a low hanging fruit, which is good for me)?
  2. Talks have a video_url attribute, but I don't see any code that is actually adding the URLs to them. So how does adding video_urls works? Are we actually adding those URLs?

Otherwise - it looks as simply adding a button "See video" to the talk.html template if the video_url exists. Or is there more to this ticket?

@umgelurgel
Copy link
Contributor Author

I remembered working on it - some digging around revealed that I never pushed the changes I had locally; they're now in #1176 - they show the video URL on the page and include a script that fetches the metadata for the video. There is no way currently to match that metada against existing talks though - is that something that you think you'd have availability to work on?

@fpierfed fpierfed added 2022 and removed 2019 labels Jul 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
EP2020
  
To do
Development

No branches or pull requests

3 participants