Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

returnUrl is ignored in redirectToSignIn #70

Open
regan-sarwas opened this issue Nov 2, 2016 · 3 comments
Open

returnUrl is ignored in redirectToSignIn #70

regan-sarwas opened this issue Nov 2, 2016 · 3 comments

Comments

@regan-sarwas
Copy link

This code seems to do the right thing, but after signing in, I go to my default home page on AGOL instead of returning to my app. Try https://regan-sarwas.github.io/storymaps/mapjournal/index.html?fromScratch. This was built from master on 2016-10-31

@oevans
Copy link
Member

oevans commented Nov 3, 2016

@regan-sarwas -- This is because there is no OAuth id specified in the index.html file. If you register the app and add the OAuthID to the index.html file you'll be redirected to the builder after logging in. Let me know if that works for you.

@regan-sarwas
Copy link
Author

Hmm.. If that case, I think you have a bug. You should not be calling redirectToSignIn() unless the code provides an OauthID. The code in core.js certainly does not imply that Oauth is required for redirectToSignIn. To me it appears just the opposite.

BTW, Signing In for direct creation works just fine if you delete the code that calls redirectToSignIn().

Nevertheless, I will try to test with Oauth.

@oevans
Copy link
Member

oevans commented Nov 4, 2016

OK, thx for reporting this Regan. We'll look into this one as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants