You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The problem is that the build path in rootDir has a semicolon (something like /D:/..), and it is causing an exception in Linux based shells like Gitbash.
Reproduction
You will probably need a Windows machine a follow any of the instructions (e.g. job demo instructions)
Logs
Sorry, I don't have them.
System Info
Windows 11.
It was this repo at this point, so ArcGIS REST JS Version: 4.1.4
Additional Information
Sorry, I can not provide more context. It was an easy fix, we just removed the semicolon locally, but I don't have time to submit a PR right now, but I wanted to at least issue this.
The text was updated successfully, but these errors were encountered:
> @esri/arcgis-rest-geocoder-vanilla@3.3.0 start
> node ../../scripts/run-demo-server.js
node:internal/errors:496
ErrorCaptureStackTrace(err);
^
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received null
at new NodeError (node:internal/errors:405:5)
at validateString (node:internal/validators:162:11)
at join (node:path:429:7)
at getPackages (file:///C:/_work/arcgis-rest-js/scripts/get-package-json.js:19:37)
at async file:///C:/_work/arcgis-rest-js/scripts/run-demo-server.js:7:20 {
code: 'ERR_INVALID_ARG_TYPE'
}
Node.js v18.17.1
npm ERR! Lifecycle script `start` failed with error:
npm ERR! Error: command failed
npm ERR! in workspace: @esri/arcgis-rest-geocoder-vanilla@3.3.0
npm ERR! at location: C:\_work\arcgis-rest-js\demos\geocoder-browser
__dirname is not being constructed properly. The root should be the project directory not the full path of the project directory on disk.
import*asurlfrom'url';import{readFile}from"fs/promises";import{globby}from"globby";importpkgDirfrom"pkg-dir";import{join}from"path";const__dirname=url.fileURLToPath(newURL('.',import.meta.url));/** * Returns an object like: * * { * packageName: package.json contents * } * * For all packages in the packages/* folder. */exportdefaultasyncfunctiongetPackages(){constrootDir=awaitpkgDir(__dirname);constpackageFiles=awaitglobby(join(rootDir,"packages/*/package.json"));returnPromise.all(packageFiles.map((pkgPath)=>{returnreadFile(pkgPath).then((pkg)=>{returnJSON.parse(pkg);});}));}
Describe the bug
While trying to run
npm start
on Windows in the demo folders, which runsnode ../../scripts/run-demo-server.js
it throws an error in the following line:https://github.com/Esri/arcgis-rest-js/blob/main/scripts/get-package-json.js#L19
The problem is that the build path in
rootDir
has a semicolon (something like/D:/..
), and it is causing an exception in Linux based shells like Gitbash.Reproduction
You will probably need a Windows machine a follow any of the instructions (e.g. job demo instructions)
Logs
Sorry, I don't have them.
System Info
Additional Information
Sorry, I can not provide more context. It was an easy fix, we just removed the semicolon locally, but I don't have time to submit a PR right now, but I wanted to at least issue this.
The text was updated successfully, but these errors were encountered: