Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version numbers in header of dist files do not match actual version #1105

Open
gavinr opened this issue Jun 2, 2023 · 1 comment
Open

Version numbers in header of dist files do not match actual version #1105

gavinr opened this issue Jun 2, 2023 · 1 comment

Comments

@gavinr
Copy link
Contributor

gavinr commented Jun 2, 2023

Describe the bug

It seems like the comment in the header of the dist files has the version of the previous release instead of the current release.

https://unpkg.com/@esri/arcgis-rest-request@4.2.0/dist/bundled/request.umd.min.js
image

Reproduction

  1. Open https://unpkg.com/@esri/arcgis-rest-request@4.2.0/dist/bundled/request.umd.min.js
  2. See the second line:
    • Expected: * @esri/arcgis-rest-request - v4.2.0 - Apache-2.0
    • Actual: * @esri/arcgis-rest-request - v4.1.4 - Apache-2.0

This also happens in previous versions - for example see https://unpkg.com/@esri/arcgis-rest-request@4.1.3/dist/bundled/request.umd.min.js

Logs

No response

System Info

ArcGIS REST JS Version: v4.2.0
(but it looks like this also happens with previous versions)

Additional Information

No response

@gavinr
Copy link
Contributor Author

gavinr commented Jun 22, 2023

Discussed 6/22:

  • if someone has time, looking through the build process to see if the order of "build" and "deploy" is in the wrong order
  • Or if it's too tough to figure out the auto-release process, maybe we just remove the version number for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant