Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari has weird colors in dark mode #1

Open
EricAndrechek opened this issue May 28, 2022 · 2 comments
Open

Safari has weird colors in dark mode #1

EricAndrechek opened this issue May 28, 2022 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@EricAndrechek
Copy link
Owner

While in Safari (only tested on mobile safari on iPhone) some of the link and button colors appear as orange instead of blue. Additionally, the text box to type the answers in sometimes appears as white.

CSS will need to be looked at and potentially a new hacky solution put in place specifically for Safari's rendering engine.

@EricAndrechek EricAndrechek added bug Something isn't working help wanted Extra attention is needed labels May 28, 2022
@Haadi-Khan
Copy link
Contributor

Potentially helpful information:

I use the hyperweb extension for safari on my phone, and it has a dark theme plugin built in. If I toggle dark mode on the site, and also have the dark mode from hyperweb on, it switches from the orange color to the blue you would expect. Maybe just hard setting some of the css (aka just the colors) instead of relying in the import could be an easy fix. Given that hyperweb is just adding additional css I don't think it'd be too hard. I can't readily test safari though, so I don't know how much help I can be.

Side note, as you'd expect hyperweb + site light theme works well and renters just how you'd expect.

@EricAndrechek
Copy link
Owner Author

Yeah, I suppose since the codebase is small and minimal I could probably just hard code the CSS values to make those changes rather than attempt to apply them automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants