Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Logger is not very usefull when receiving corrupted data. #370

Open
2 tasks done
Hadatko opened this issue Aug 10, 2023 · 0 comments
Open
2 tasks done

[BUG] Logger is not very usefull when receiving corrupted data. #370

Hadatko opened this issue Aug 10, 2023 · 0 comments
Assignees
Labels
Milestone

Comments

@Hadatko
Copy link
Member

Hadatko commented Aug 10, 2023

Describe the bug

When corrupted data are received (crc check fail) logger action is skipped. We now that fail occured but we cannot figure out why as we don't see message.

To Reproduce

Send message with wrong crc to server.

Expected behavior

I think we can refactor code a bit to developer decide if he want log all messages or only good messages and moved code to better place than client/server initialization as it is really tight to transport.

Screenshots

image

Desktop (please complete the following information):

  • OS:
  • eRPC Version:

Steps you didn't forgot to do

  • I checked if there is no related issue opened/closed.
  • I checked that there doesn't exist opened PR which is solving this issue.

Additional context

@Hadatko Hadatko added the bug label Aug 10, 2023
@Hadatko Hadatko added this to the 1.12.0 milestone Aug 10, 2023
@Hadatko Hadatko self-assigned this Aug 10, 2023
@Hadatko Hadatko removed this from the 1.12.0 milestone Sep 18, 2023
@Hadatko Hadatko added this to the 1.13.0 milestone Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant