Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo-vet check #429

Open
Jake-Shadle opened this issue Jun 8, 2022 · 1 comment
Open

Add cargo-vet check #429

Jake-Shadle opened this issue Jun 8, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@Jake-Shadle
Copy link
Member

cargo-vet allows project's to evaluate audit trails for dependencies, something that is very interesting for cargo-deny to support, either as an additional check, or perhaps as an addition to the bans check. This functionality could be useful for either implementing or complementing features such as #19

See mozilla/cargo-vet#82 for the issue to actually make cargo-vet usable as a library.

@Jake-Shadle Jake-Shadle added the enhancement New feature or request label Jun 8, 2022
@repi
Copy link
Contributor

repi commented Nov 19, 2022

I was initially thinking that we can just run cargo-vet manually in CI instead of having it integrated in cargo-deny, as it would be standalone and wouldn't use any of the other cargo-deny features and has its own configurations instead of deny.toml.

Though one really good benefit of having it integrated here would be that it would streamline CI workflows, we already run cargo-deny in all of our private and public repositories and both through CI image installs of cargo-deny and of through our Github Action. So if we had a cargo deny check audits that does run an embedded library version of cargo-vet that only can validate that crates are vetted/audited (not update audits or user workflows) that would be easier for CI.

So I'm all in favor of this! And think we we should try and do it this way, if possible, rather than installing and adding cargo-vet manually to our CI steps. Though depends on when we can have the library version, think we want to enable cargo-vet CI checks within a couple of months max.

Developers would still have to have cargo-vet installed locally though to be able to interact with it to add new audits, do diffs and such, but think that is fine. And later on hopefully we'll get an interactive GitHub workflow for that to diff and add audits in a PR instead:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants