Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting chrome.topSites api #21

Open
usamaejaz opened this issue Nov 21, 2017 · 3 comments
Open

Supporting chrome.topSites api #21

usamaejaz opened this issue Nov 21, 2017 · 3 comments

Comments

@usamaejaz
Copy link

I wanted to use the chrome.topSites api but it was not already in the scripts/utils/ext.js. Just wanted to leave a note here that it "topSites" api is not in the array by default.

@kgoedecke
Copy link

Did you try usingbrowser.topSites?

@usamaejaz
Copy link
Author

usamaejaz commented Nov 21, 2017

@kgoedecke using browser.topSites or even chrome.topSites directly is fine. But i am talking about proxying the apis.

scripts/utils/ext.js:

const apis = [
  'alarms',
  'bookmarks',
  'browserAction',
  'commands',
  'contextMenus',
  'cookies',
  'downloads',
  'events',
  'extension',
  'extensionTypes',
  'history',
  'i18n',
  'idle',
  'notifications',
  'pageAction',
  'runtime',
  'storage',
  'tabs', 
  'topSites', // <------------- this. 
  'webNavigation',
  'webRequest',
  'windows',
]

It will be better if that api is there by default.

@usamaejaz
Copy link
Author

Same for management

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants