Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

[FEATURE] Replace repository forks #369

Open
4 of 13 tasks
EliteMasterEric opened this issue Apr 22, 2021 · 0 comments
Open
4 of 13 tasks

[FEATURE] Replace repository forks #369

EliteMasterEric opened this issue Apr 22, 2021 · 0 comments
Labels
enhancement A new feature for the site. technical Technical improvements such as performance fixes or code coverage

Comments

@EliteMasterEric
Copy link
Owner

EliteMasterEric commented Apr 22, 2021

The packages folder of the repository is used to contain submodules, representing forks of other repositories which required changes or fixes in order to function properly for the map. This is necessary for development, but is bad practice and the required changes should be added to the main project and the fork removed as soon as possible.

The following checklist breaks down each repository, why they were forked, and the status on merging the changes.

Packages:

  • react-leaflet
    • Resolved an issue where several marker options were ignored on update. Repository owner marked as WON'T FIX.
  • Leaflet.Editable
    • Populated propagatedFrom on events. Pull request not yet submitted.
  • Leaflet
    • Add a handler to catch a detached map issue. Pull request not yet submitted.
  • leaflet.markercluster
    • Refresh clusters on unspiderfy. Pull request not yet submitted.
    • Add option to spiderfy on every zoom. Pull request pending.
    • spiderfyShapePositions now receives the full list of child markers. Pull request pending.
    • Can also replace with PlacementStrategy plugin.
  • leaflet.textpath
  • react-leaflet-textpath
  • next-transpile-modules
  • redux-toolkit
  • localized-strings
  • react-localization
    • Fix Typescript definitions.
    • Fix peer dependency issue.

Type Packages:

  • @types/leaflet-textpath
    • Added new package. Pull request merged into DefinitelyTyped.
  • @types/react-leaflet
    • Added missing event onZoom. Pull request merged into DefinitelyTyped.
  • @types/leaflet-editable
    • Updated to version 1.2.0. Pull request merged into DefinitelyTyped.
@EliteMasterEric EliteMasterEric added enhancement A new feature for the site. technical Technical improvements such as performance fixes or code coverage labels Apr 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement A new feature for the site. technical Technical improvements such as performance fixes or code coverage
Projects
None yet
Development

No branches or pull requests

1 participant