Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump-lists missing #16

Open
GoogleCodeExporter opened this issue Apr 5, 2015 · 12 comments
Open

Jump-lists missing #16

GoogleCodeExporter opened this issue Apr 5, 2015 · 12 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Start the program
2. Right click on the icon in the taskbar

What is the expected output? What do you see instead?
I expect something akin to the screenshot shown here, 
http://pidgin-win7.googlecode.com/svn/trunk/pidgin-jumplist.png , but, instead, 
I only get the default ("Pidgin", "Unpin this program from the taskbar" and  
"Close window") entries.

Please provide any additional information below.
Note that this might be a windows issue, perhaps they changed the api?
I suspec this as I'm expiriencig a similar problem with a win7 plugin for 
foobar (http://wintense.com/plugins/foo_w7shell).
Note that other third party programs (Firefox, at least) work fine.

Original issue reported on code.google.com by nikri...@gmail.com on 7 Mar 2011 at 9:31

@GoogleCodeExporter
Copy link
Author

Just to check, did you enable the plugin in Tools->Plugins?

Original comment by eionrobb on 7 Mar 2011 at 9:34

@GoogleCodeExporter
Copy link
Author

Heh, yes, I did.

Just to clear thigs up: the other features are present. Pidgin closes to the 
taskbar, the overlays are drawn, etc.

Just the jump-lists are missing.

Original comment by nikri...@gmail.com on 7 Mar 2011 at 9:36

@GoogleCodeExporter
Copy link
Author

Ok :)  Have to check these things

If you disable then re-enable the plugin, does the jumplist show?  What does 
the debug log show?  (from the buddy list, Help->Debug Window)

Original comment by eionrobb on 7 Mar 2011 at 9:55

@GoogleCodeExporter
Copy link
Author

Tried re-enabling, to no effect (I've never actually seen the jump-lists on 
pidgin).

The Debug Window doesn't show anything on right-clicking the icon (should it?)
The only interesting thing in it, is the occasianal "GLib: g_source_remove: 
assertion `tag > 0' failed", but that happens with or without the plugin 
enabled.

(note that, on disabling the plugin, I get 4 lines of: "g_log: 
purple_signal_disconnect: assertion `found' failed"

Original comment by nikri...@gmail.com on 7 Mar 2011 at 10:37

@GoogleCodeExporter
Copy link
Author

I'm more interested in what the debug window says when you re-enable the plugin 
:)

Original comment by eionrobb on 7 Mar 2011 at 11:03

@GoogleCodeExporter
Copy link
Author

OK, piping...

(09:08:43) win7: plugin_load
(09:08:43) win7: create_jumplist
(09:08:43) win7: Beginlist begun
(09:08:43) win7: add_tasks
(09:08:43) win7: pidgin_path C:\Program Files\Pidgin\pidgin.exe
(09:08:43) win7: create_shell_link
(09:08:43) win7: create_shell_link
(09:08:43) win7: create_separator
(09:08:43) win7: create_shell_link
(09:08:43) win7: create_shell_link
(09:08:43) win7: create_shell_link
(09:08:43) win7: create_shell_link
(09:08:43) win7: create_shell_link
(09:08:43) win7: create_separator
(09:08:43) win7: create_shell_link
(09:08:43) win7: create_shell_link
(09:08:43) win7: create_shell_link
(09:08:43) win7: create_shell_link
(09:08:43) gtkblist: added visibility manager: 2
(09:08:43) win7: win7_on_status_change
(09:08:43) prefs: /pidgin/plugins/loaded changed, scheduling save.
(09:08:44) skype: Sending: 'PING'
(09:08:44) skype: Received: PONG
(09:08:46) util: Writing file prefs.xml to directory 
C:\Users\nikola.rajacic\AppData\Roaming\.purple
(09:08:46) util: Writing file 
C:\Users\nikola.rajacic\AppData\Roaming\.purple\prefs.xml

...

Original comment by nikri...@gmail.com on 8 Mar 2011 at 8:10

@GoogleCodeExporter
Copy link
Author

Darn, that looks normal, and it looks like there's no error when creating the 
shell links/jump list menu items.

I'll see if I have time to make another build for you with some more debug info 
to try and track this down.

Original comment by eionrobb on 8 Mar 2011 at 9:02

@GoogleCodeExporter
Copy link
Author

If it's any help, I'm on build 7600, Windows 7 Professional, x64

Apparently, they change things around a bit from build to build in the dwm, 
perhaps, something related to jump lists, as well?

Original comment by nikri...@gmail.com on 8 Mar 2011 at 9:07

@GoogleCodeExporter
Copy link
Author

Ok, looked a bit more, the jumps are actually working (kinda :P), just not the 
way (where) I'd expect them to :)

The actual problem is rooted in the way windows separates/merges the taskbar 
items (which is by application ID).

Now, I'm not exactly sure how the OS chooses it (I assume it gets hints from 
the app), but it basically uses the path to the exe. Now, the problem I 
experienced was that, depending on the method I used to pin the app, I'd get 
TWO different App ID's, and two separate items in the taskbar!

If I'd right-click on the .exe (but NOT the short-cut!), and select "pin to 
taskbar", the Application ID would be: C:/Program Files/Pidgin/Pidgin.exe
This taskbar item would have jump lists, but, it woulden group with the actuall 
app, once ran!
However, if I'd drag the app to the taskbar, or right click on a short-cut or a 
running instance and select "pin to taskbar" the app ID would be: 
{6D809377-6AF0-444B-8957-A3773F02200E}\Pidgin\Pidgin.exe

(6D809377-6AF0-444B-8957-A3773F02200E is windows' GUID for "ProgramFilesX64", 
ie. "C:/Program Files" - the same place, just not quite :) )

So, basically, what I had were two short-cuts, one of which would have jump 
lists, and the other other would actually "hold" the app (min/max/etc...)

Now, the reason I'm the only one expiriencing this is that I'm prolly the only 
one who installed piding into "C:/Program Files/" and not "C:/Program Files 
(x84)".
Once I reinstalled there, which ever way you pin it, you get the same thing: 
{7C5A40EF-A0FB-4BFC-874A-C0F2E0B9FA8E}\Pidgin\Pidgin.exe, and that always seems 
to work. :)

So, basically, what I believe needs review is the part of your code generating 
the Application IDs, otherwise your plugin would work on instances installed to 
the (x86) folder.
Perhaps 
http://stackoverflow.com/questions/2870417/adding-items-to-other-applications-ta
skbar-menu-in-windows-7 (and the links on it) could be helpful.

Original comment by Nikola.D...@gmail.com on 5 May 2011 at 11:46

@GoogleCodeExporter
Copy link
Author

Well, on another machine (the first I tried the bug with), I can't even seem to 
reproduce the correct behaviour, even when installing to the (x86) directory! :D

So, finally, I just moved it to another place altogether (D:\Program 
Files\Pidgin)
Now it groups fine, but it only shows some of the jump-list items! :D:D

I now see "New Message", "Join Chat", "Available", "Away" and "Do Not Disturb".
On the other machine, I also have "Invisible", "Offline", and the 
"Accounts/Plugins/Preferences/Quit" block.

What could possibly delete SOME of these?

(no amount of reinstalls/moving files around/etc. helped here)

Original comment by Nikola.D...@gmail.com on 5 May 2011 at 2:33

@GoogleCodeExporter
Copy link
Author

Thanks for the super-human debugging, Nikola!  I've just commited some code 
which sets the Application ID so should fix the issue.  I'll build a new dll 
for you to test with later on today.

The other issue of some jumplist items showing, but not all, is generally due 
to windows having a limit on the number of items on smaller screens.

Original comment by eionrobb on 5 May 2011 at 8:09

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Well, that one's really weird since it works ok an identical computer with the 
same screen size (22 inches).

Might it have something to do with the custom theme I'm using?
(I've had size issues with another 3rd-party app 
http://sourceforge.net/tracker/?func=detail&atid=1230788&aid=3196088&group_id=29
0975)

(will compare as soon as I get hold of that machine again :) )

Original comment by Nikola.D...@gmail.com on 5 May 2011 at 8:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant