Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Config] Render all Durations as human-readable string #238

Open
roma-glushko opened this issue May 5, 2024 · 3 comments
Open

[Config] Render all Durations as human-readable string #238

roma-glushko opened this issue May 5, 2024 · 3 comments
Assignees
@ppmdo
Labels
api:http area:api area:config good first issue Good for newcomers help wanted Extra attention is needed model:language size:small type:enhancement New feature or request

Comments

@roma-glushko
Copy link
Member

Let's render all Durations like retry.min_delay, retry.max_delay, client.timeout as human-friendly strings (e.g. 5s):

2024-05-05_15-34-13
@ppmdo
Copy link
Contributor

ppmdo commented May 6, 2024

Hi, nice project!

I can take a look into this. Please assign it to me.

@roma-glushko
Copy link
Member Author

@ppmdo appreciate that Pablo 🙏

@daesu
Copy link
Contributor

daesu commented May 6, 2024

Apologies @roma-glushko @ppmdo I didn't see you had taken this. I have a PR here

ppmdo added a commit to ppmdo/glide that referenced this issue May 9, 2024
@ppmdo
Implements human readable durations in config, fixes EinStack#238
22c9dc9
ppmdo added a commit to ppmdo/glide that referenced this issue May 9, 2024
@ppmdo
Implements human readable durations in config, fixes EinStack#238
fbbf7ef
ppmdo added a commit to ppmdo/glide that referenced this issue May 9, 2024
@ppmdo
Implements human readable durations in config, fixes EinStack#238
6de012d
roma-glushko pushed a commit that referenced this issue May 22, 2024
@ppmdo
🔧 #238 Implements human readable durations in config (#253)
03f1805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppmdo ppmdo

Labels
api:http area:api area:config good first issue Good for newcomers help wanted Extra attention is needed model:language size:small type:enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daesu @roma-glushko @ppmdo