Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper error handling to reducers, remove .catch(...)'s from src/api/* #22

Open
elimisteve opened this issue Jan 23, 2019 · 3 comments
Open

Add proper error handling to reducers, remove .catch(...)'s from src/api/* #22

elimisteve opened this issue Jan 23, 2019 · 3 comments
Assignees
@Mattimus333

Comments

@elimisteve
Copy link
Member

No description provided.

@elimisteve
Copy link
Member Author

@Moe-Shoman ^^

@elimisteve elimisteve mentioned this issue Jan 23, 2019
Merged
@elimisteve
Copy link
Member Author

@Mattimus333 @Moe-Shoman Who wants to work on this one?

@elimisteve
Copy link
Member Author

@Mattimus333 This would make our error handling waaay better by mostly just stripping off the .catch(...)s in src/api/*.js and adding some _REJECTED reducers that set error + toasts that display said errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mattimus333 Mattimus333

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elimisteve @Mattimus333