feat(color): support PPM_US setting #4987
Conversation
pfeerick
added
color
philmoz
force-pushed
the
color-ppm-us
branch
2 times, most recently
from
25b34ed
to
1eb3e3c
Compare
pfeerick
changed the title
|
This looks to be perfect on TX16... thank you! 😍 Not related to this PR implementation - do you think the Override special function being a percentage (-100 to 100) is inconsistent when the system is configured to be using |
Possibly, and there are probably other places as well. To be honest I don't use this and personally don't see the advantage of seeing value this way, so I'm not sure where else it should apply. |
|
I think the advantage is that it is the actual value sent... and is not relative to anything... -100% - 100% of what / relative to what? 1000ms-2000ms? 988-2012ms? As sometimes this does matter... this is why outputs to BF are supposed to be scaled -97.7 to 97.7 ms... so it is exactly 1000ms - 2000ms, which then feeds in the FCs mixing, Then you have servos that have much broader ranges, such as 360 and continuous rotation servos... so sometimes it is very necessary, but is also somewhat a niche/legacy thing. Personally I've had no use for |
Fixes #4977 and #3163
I've tried to match all the places that the PPM_US setting is used on B&W radios.
Channel monitor. Note if using PPM_US setting the value at the right above each channel changes to % instead of showing us value.
Custom failsafe settings:
Outputs list (min/max values):
Outputs widget:
