Fix collection template for not numeric children keys #6280
Conversation
| @@ -137,7 +137,7 @@ | |||
| 'data-entry-is-complex': form.vars.ea_vars.field and form.vars.ea_vars.field.customOptions.get('entryIsComplex') ? 'true' : 'false', | |||
| 'data-allow-add': allow_add ? 'true' : 'false', | |||
| 'data-allow-delete': allow_delete ? 'true' : 'false', | |||
| 'data-num-items': form.children is empty ? 0 : max(form.children|keys) + 1, | |||
| 'data-num-items': form.children is empty ? 0 : form.children|length, | |||
There was a problem hiding this comment.
This doesn't work if the array has numeric keys not starting by 0.
And it's quite common to use the entity id as the index.
There was a problem hiding this comment.
And it's quite common to use the entity id as the index.
Collection field does not handle indexes at all. Even field named "num-items" (read as count).
Needed only to be "unique" in js.
And yes, it must be numeric, but indexes may not (check #6277)
EasyAdminBundle/assets/js/field-collection.js
Lines 33 to 34 in ca0e6c5
A fictional problem brought problems
There was a problem hiding this comment.
Please take a look on this thread to see how indexed collection using ids are used:
symfony/symfony#7828 (comment)
There was a problem hiding this comment.
Just to be clear, if I have 2 items in my collection with index not starting by 0:
1 => item 1,
2 => item 2,
With your solution, form.children|length will return 2 and the new item added will have the same key 2 as the second item which is wrong.
There was a problem hiding this comment.
I know what you mean, but it is weird idea doing so here.
And yes, I know that this fix may bring collisions, but don't know how properly resolve it.
Probably need some refactoring - there is already many crutches
There was a problem hiding this comment.
Maybe filtering only numeric key?
max(form.children|keys|filter(k => k matches '/^\\d+$/')) + 1
There was a problem hiding this comment.
Another crutch :)
With string keys all new items will be 1
There was a problem hiding this comment.
Probably it resolve problem in moment, as after save it become normal keys and "unique" will be satisfied.
But I don't envy those who will support it later )
Fix #6277