Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemoryManager default options #1371

Open
onionhammer opened this issue Mar 22, 2024 · 1 comment
Open

MemoryManager default options #1371

onionhammer opened this issue Mar 22, 2024 · 1 comment
Labels

Comments

@onionhammer
Copy link

Couple small issues here:

  1. ".MemoryManger" is a typo, I assume, and should be "MemoryManager"
  2. While it is now possible to override the options EPPlus uses, the documentation for RecyclableMemoryStream says the following

It is through these properties that you determine how large your pool can grow. If you set these to 0, you can have unbounded pool growth, which is essentially indistinguishable from a memory leak. For every application, you must determine through analysis and experimentation the appropriate balance between pool size and garbage collection.

Source: https://github.com/microsoft/Microsoft.IO.RecyclableMemoryStream

Currently, if an EPPlus user does not manually override the "MemoryManger", and continually uploads larger and larger files, the default behavior of EPPlus will be to hold onto as much memory as at least as big as the biggest file processed.

@JanKallman
Copy link
Contributor

Thanks for reporting this. We will correct the typo and have a look at the default behaviour.

@swmal swmal added enhancement New feature or request needs investigation labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants