Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMsoftData_DIR not set after git pull #171

Open
gpezza2 opened this issue May 3, 2023 · 0 comments
Open

EMsoftData_DIR not set after git pull #171

gpezza2 opened this issue May 3, 2023 · 0 comments

Comments

@gpezza2
Copy link

gpezza2 commented May 3, 2023

I seem to have run into a bug when building EMsoft 5.0.4 (develop branch) when making the Tests. Source/Test/CMakeLists.txtm Lines 88-100. First conditional checks if the EMsoftData_DIR location exists, and if so, sets it:

if(EXISTS "${EMSOFT_PARENT}/EMsoftData")
set(EMsoftData_DIR ${EMSOFT_PARENT}/EMsoftData)

If it doesn't exists, it then does a git pull to get it. However, it then never sets the EMsoftData_DIR variable. If run on persistent storage, it seems running the setup twice will work as the first time pulls it then errors out further along, and second time it will find the directory and keep going. However, when trying to build an apptainer container, this doesn't work as the files get purged with every run. a manual git pull of the repo fixed it so it exists before the setup scripts are run. However, it might be better to just run the same "set(EMsoftData_DIR ${EMSOFT_PARENT}/EMsoftData)" after the "ExternalProject_Add" call completes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant