Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JakartaEE 10 support #110

Open
JSamir opened this issue Feb 26, 2024 · 4 comments
Open

JakartaEE 10 support #110

JSamir opened this issue Feb 26, 2024 · 4 comments

Comments

@JSamir
Copy link

JSamir commented Feb 26, 2024

We are migrating our application to JakartaEE 10 and faced issues, it seems the client does not support running in JakartaEE 10 context.

Is there a plan to make it JEE10 compatible?

@dunedodo
Copy link
Contributor

Currently we have not planned targeting JakartaEE.

@JSamir
Copy link
Author

JSamir commented Apr 12, 2024

Since we were migrating our own application and therefore are familiar with the topic, we tried patching the ecs client ourselves. In general it works for us, although someone with knowledge about the internals of the client would need to have a look at few minor issues.

Would you accept a PR?

@dunedodo
Copy link
Contributor

Yes, please. We will help review.

@JSamir
Copy link
Author

JSamir commented May 10, 2024

We're currently building a release thus I will only have time for the PR in 1-2 weeks.

But one thing I wanted to mention already is that the changes we have made would make things work with JEE10, but JEE8 would not work (anymore). So you would either need to drop JEE8 support or somehow make both work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants