Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unpublishing featured actions better #773

Open
esoterik opened this issue Nov 7, 2019 · 0 comments
Open

Handle unpublishing featured actions better #773

esoterik opened this issue Nov 7, 2019 · 0 comments

Comments

@esoterik
Copy link
Member

esoterik commented Nov 7, 2019

Right now, if you unpublish an action page that is featured, this callback runs:

def no_drafts_on_homepage                                                                                                           
  FeaturedActionPage.where(action_page_id: id).destroy_all unless published?   
end                                                                            

This means that fewer than 4 actions end up being featured, until someone edits the featured actions again. I'm not sure what the best way to fix this is, but it's not intuitive right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant