詳細検索での電話番号のバリデーションを修正 #6189
Open
詳細検索での電話番号のバリデーションを修正 #6189
+4
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.3 #6189 +/- ##
==========================================
- Coverage 82.76% 82.75% -0.01%
==========================================
Files 480 480
Lines 26431 26419 -12
==========================================
- Hits 21876 21864 -12
Misses 4555 4555
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@mmikri |
dotani1111
requested review from
chihiro-adachi,
shinya,
dotani1111 and
ji-eunsoo
|
@dotani1111 |
|
動作確認してマージします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
会員検索のバリデーションのメッセージが一貫していない
close #6170
方針(Policy)
実装に関する補足(Appendix)
電話番号は数字のみが登録可能な仕様になっていたため、検索フォームも同様に数字のみで検索できるようにバリデーションを修正しました。
テスト（Test)
以下2つの画面が対象となります。
相談（Discussion）
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目