Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop flags disappear when changing linked file #574

Open
e9gille opened this issue Sep 4, 2023 · 3 comments
Open

Stop flags disappear when changing linked file #574

e9gille opened this issue Sep 4, 2023 · 3 comments

Comments

@e9gille
Copy link
Collaborator

e9gille commented Sep 4, 2023

I thought this was working already, but I can see that changing a linked file clears the stop (and trace/monitor) flags. Looks like this was fixed and then removed back in v2 and I know there's work to revamp this in v4, but any chance we can get this fixed in v3.0?

⍝:If (⌊|where.⎕NC⊂name)∊3 4 ⋄ (stops trace monitor)←(where.⎕STOP name)(where.⎕TRACE name)(⊣/where.⎕MONITOR name) ⍝ link issue #148 and #129

@e9gille
Copy link
Collaborator Author

e9gille commented Sep 4, 2023

Re-instated lines 703-705 and 714-716 in file below. It seems to work as expected, but do you recall why they were taken out? I fear they caused issues seeing as they are commented out.
https://github.com/Dyalog/link/blob/3.0/StartupSession/Link/Utils.apln#L703

@e9gille
Copy link
Collaborator Author

e9gille commented Sep 4, 2023

This is where they were taken out
d0863e1

@e9gille
Copy link
Collaborator Author

e9gille commented Sep 12, 2023

Having tested this it looks like there is very little overhead in running the re-instated lines, so they were probably not removed for performance reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant