Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide GO button on mobile #4

Open
abrudz opened this issue Jul 15, 2021 · 8 comments · May be fixed by #49
Open

Provide GO button on mobile #4

abrudz opened this issue Jul 15, 2021 · 8 comments · May be fixed by #49
Assignees
Labels
enhancement New feature or request

Comments

@abrudz
Copy link
Contributor

abrudz commented Jul 15, 2021

When hiding the single-line input field, replace it with a purple ▷ in the lower right, for mobiles without Enter

@abrudz abrudz added the enhancement New feature or request label Jul 15, 2021
@sloorush
Copy link
Member

sloorush commented Apr 10, 2024

Hi @abrudz, Do you have any suggestions as to where the button should be on the screen?

Edit: Do you think adding a floating purple button on the bottom right corner is a good choice?

image

@abrudz
Copy link
Contributor Author

abrudz commented Apr 15, 2024

I don't see any better options, but why do we hide the single-line input field on mobile?

@sloorush
Copy link
Member

why do we hide the single-line input field on mobile?

That is true, I think the single line input field could also solve the issue.

@sloorush
Copy link
Member

From what I could find, it is intentionally hidden on mobile devices. It was done in the initial git (GitHub) commit. Do we have any old git or svn history to find more information on why it was done?

TryAPL/style.css

Lines 27 to 31 in 7cc020a

/* Hide oneLineInput on mobile */
@media only screen and (max-width: 600px) {
#oneLineInput {visibility: hidden;}
#oneLineSubmit {visibility: hidden;}
}

@abrudz
Copy link
Contributor Author

abrudz commented Apr 16, 2024

There was private history before then. @rikedyp might remember why we did this, but at this point, I think we can just always show it.

@sloorush
Copy link
Member

I think I found out why it was intentionally hidden:

So it looks like this when I test on my PC browser emulating a phone (All good):

image

But it looks like this default on the phone (single line bar is hidden behind the bottom menu bar):

But if I zoom out and the browser enables a (kind of) full-screen mode it looks like this (All good):

@sloorush sloorush linked a pull request Apr 16, 2024 that will close this issue
@abrudz
Copy link
Contributor Author

abrudz commented Apr 16, 2024

Ah yes, I remember now. The mobile browser will hide the bottom of the screen with a keyboard. We really should implement on-screen keyboard ourselves…

@sloorush
Copy link
Member

Ah okay! I will try to get it to be visible or add the circle floating run button as we discussed above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants