Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrypted google-services.json #683

Open
rynkowsg opened this issue Feb 27, 2019 · 1 comment
Open

Decrypted google-services.json #683

rynkowsg opened this issue Feb 27, 2019 · 1 comment

Comments

@rynkowsg
Copy link

Overview (Required)

Your google-services.json file contains some secrets. I guess you are aware of it since you decrypt it in your CI step, so I suppose adding the decrypted file into the repo history had to be a mistake.

Links

history of decrypted google-services.json file:
https://github.com/DroidKaigi/conference-app-2018/commits/f19dd63f8b691d44ba7f758d92c2ca615cdad08d/app/google-services.json

@jmatsu
Copy link
Contributor

jmatsu commented Feb 28, 2019

Thank you for getting in touch.

That's done on purpose. The json file you have attached and the encrypted json file differ.

https://github.com/DroidKaigi/conference-app-2018/commits/f19dd63f8b691d44ba7f758d92c2ca615cdad08d/app/google-services.json

This json is only for development and uses free plan.

https://github.com/DroidKaigi/conference-app-2018/blob/master/encrypted-google-services.json

This json is for production. CI will overwrite /app/google-services.json with this json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants