Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply textIsSelectable = true for FeedFragment text (お知らせ) #559

Open
takahirom opened this issue Feb 2, 2018 · 3 comments · Fixed by #562
Open

Apply textIsSelectable = true for FeedFragment text (お知らせ) #559

takahirom opened this issue Feb 2, 2018 · 3 comments · Fixed by #562
Labels
easy high priority welcome contribute

Comments

@takahirom
Copy link
Member

Overview (Required)

  • Probably we share wifi SSID and password.
  • It is useful when user copying that.
@takahirom takahirom added this to the 1.1.0(〜02/06) milestone Feb 2, 2018
@nappannda
Copy link
Contributor

🤚

@takahirom
Copy link
Member Author

This is high priority task! So thank you very much! Assigned 👍

@takahirom takahirom changed the title Apply textIsSelectable = true for FeedFragment text (お知らせ) [Assigned] Apply textIsSelectable = true for FeedFragment text (お知らせ) Feb 2, 2018
@nappannda nappannda mentioned this issue Feb 2, 2018
Merged
@takahirom takahirom reopened this Feb 4, 2018
@takahirom
Copy link
Member Author

This pull request reverted.
We should use textIsSelectable = true. But we should not break the layout.
image

@takahirom takahirom changed the title [Assigned] Apply textIsSelectable = true for FeedFragment text (お知らせ) Apply textIsSelectable = true for FeedFragment text (お知らせ) Feb 4, 2018
@takahirom takahirom removed the assigned label Feb 4, 2018
@konifar konifar removed this from the 1.1.0(〜02/05) milestone Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy high priority welcome contribute
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply item_feed content textIsSelectable nappannda/conference-app-2018
3 participants
@konifar @takahirom @nappannda