Add a Unity-compatible Boxed.Mapping.Unity package #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
RehanSaeed
reviewed
May 17, 2023
|
Build is failing. Haven't had time to take a look yet. |
|
Okay, thanks for update |
|
@RehanSaeed any updates on this one? |
|
Apologies, I'm having difficulty finding the time. Not had a chance to see what is wrong with the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new Boxed.Mapping.Unity package that fixes Unity incompatibilities described in #592
Implementation notes:
UNITYdefine symbol. Instead, I've made a separate copy of theFactory.csfile and added a<Compile Remove>tag to the.csprojs. I think this is a more readable and maintainable approach.[MethodImpl(MethodImplOptions.AggressiveInlining)]attribute to theFactory<T>.CreateInstance()method. This will hint Unity to try and inline the method.Closes #592