Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Box> should use a separate variable for border colours other than --reactist-divider-primary #816

Open
frankieyan opened this issue Feb 22, 2024 · 0 comments

Comments

@frankieyan
Copy link
Member

frankieyan commented Feb 22, 2024

馃悰 Bug report

Current behavior

In our product library, dividers and borders are different colours and have different semantic meaning.

Related figma discussion

Possible solutions

  • Expose new variables, i.e. --reactist-border-idle-tint
  • Expose a prop (e.g. showHoverState) to determine whether hover or focus states are needed, and expose variables: --reactist-border-hover-tint, --reactist-border-focus-tint. This should default to false as there shouldn't be many situations where the Box element is interactive, unless it's rendered as a different element with as.
  • Remove secondary and tertiary options

Alternatively, consider following our product library by combining inputs and border variables.

Default colours:

--reactist-border-idle-tint: #b8b8b8;
--reactist-border-hover-tint: #cccccc;
--reactist-border-idle-tint: #e6e6e6;

Environment

  • @doist/reactist version: 23.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant