Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-focus-lock should be a peer dependency #698

Open
frankieyan opened this issue Sep 2, 2022 · 0 comments
Open

React-focus-lock should be a peer dependency #698

frankieyan opened this issue Sep 2, 2022 · 0 comments

Comments

@frankieyan
Copy link
Member

馃悰 Bug report

Current behavior

It's possible for a consuming app to also have React Focus Lock installed, and if the version used in Reactist can't be deduped by npm/yarn, multiple versions can end up being bundled into the app, resulting in the two fighting for focus: https://github.com/theKashey/react-focus-lock#warning

Instead, declare it as a peer dependency so that npm/yarn can properly warn users if there is a mismatch.

Steps to reproduce the bug

Discovered while testing https://github.com/Doist/twist-web/pull/5071. If Twist is using v2.5.2, and 2.9.1 is installed with Reactist, some tests will fail.

Possible solutions

Declare React Focus Lock as a peer dependency

Environment

  • @doist/reactist version: v15.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant