Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown content has no padding #303

Open
bigint opened this issue Aug 24, 2020 · 3 comments
Open

Dropdown content has no padding #303

bigint opened this issue Aug 24, 2020 · 3 comments

Comments

@bigint
Copy link

bigint commented Aug 24, 2020

馃悰 Bug report

Current behavior

Drop down content has no padding

Steps to reproduce the bug

  1. Go to https://doist.github.io/reactist/?selectedKind=Dropdown&selectedStory=Component%20Overview&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybooks%2Fstorybook-addon-knobs
  2. Click the Trigger Button

Screenshot

Environment

In official GitHub pages, and my browser is Brave Chrome/84.0.4147.135

@gnapse
Copy link
Contributor

gnapse commented Aug 24, 2020

I'm not sure if this was the intention when this component was created, but this is probably convenient, even if not intentional. You may not always want a padding forced on you over there. This gives more freedom to the user of the component to apply a padding to other elements inside it.

Imagine for instance that You want to show a list inside the dropdown and you show lines between these list items. You'd probably prefer the list item elements to reach all the way to the borders of the dropdown and then apply the paddings to the items instead.

That being said, the storybook example should do something like that because it does look weird.

@bigint
Copy link
Author

bigint commented Aug 25, 2020

That makes sense @gnapse! You can close this if you want!

@gnapse
Copy link
Contributor

gnapse commented Aug 25, 2020

I'll leave it open as a reminder to fix that storybook example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants