Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PositioningUtils in Dropdown #126

Open
henningmu opened this issue Oct 25, 2018 · 3 comments
Open

Use PositioningUtils in Dropdown #126

henningmu opened this issue Oct 25, 2018 · 3 comments

Comments

@henningmu
Copy link
Contributor

Instead of calculating the placement ourselves it should be possible to reuse (the already tested) logic from PositioningUtils and / or the Tooltip component.

@rimildeyjsr
Copy link
Contributor

@henningmu - Can I work on this?

@gnapse
Copy link
Contributor

gnapse commented Jul 28, 2020

I'd suggest we wait to see where we land with the popover approach. This issue has been around for a while now, and a lot has happened since that may change what we do about it.

Specifically, we just migrated the tooltip to use reakit underneath (#276 to be merged and released soon), and we're in the process of doing the same for the menu (PR in the works, not yet pushed). Both of these components are key users of the popover positioning logic and by using reakit they're no longer using our internal popover solution. I'm not entirely sure right now what will this mean in the mid and long term for our popover. So maybe we can wait before investing time into this.

@rimildeyjsr
Copy link
Contributor

@gnapse - Thanks for the update! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants