Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 8: new token related issue #17

Open
Psycho7 opened this issue Feb 2, 2020 · 2 comments
Open

Part 8: new token related issue #17

Psycho7 opened this issue Feb 2, 2020 · 2 comments

Comments

@Psycho7
Copy link
Contributor

Psycho7 commented Feb 2, 2020

After introducing new tokens, many places need modification of course.
It's not hard for someone to realize we need to change defs.h and scan.c, but some files are easily ignored at first.

For example the following change, this one really took me a lot of time to figure out why my code wasn't working as expected 😭

if (tokentype == T_SEMI || tokentype == T_RPAREN)

if (tokentype == T_SEMI || tokentype == T_RPAREN)

@DoctorWkt
Copy link
Owner

I'm sad that you had problems here. Can you suggest an improvement I can make to the Readme or code which would have helped? Thanks.

@Psycho7
Copy link
Contributor Author

Psycho7 commented Feb 12, 2020

Hi @DoctorWkt . Probably just mentioning the changes in readme would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants