Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print.dsm() incorrectly reports fitting engine when "bam" is used #51

Open
dfifield opened this issue Aug 29, 2023 · 1 comment
Open

Comments

@dfifield
Copy link

Hi dsm folks!

A minor niggle:
print.dsm() incorrectly reports "Fitting engine: gam" for objects returned from dsm(..., engine = "bam").

Lines 42-48 of print.dsm.R do not include a case for bam:

if(gamm){
    cat("Fitting engine: gamm\n")
  }else if(("glm" %in% class(x)) & !any(class(x)=="gam")){
    cat("Fitting engine: glm\n")
  }else{
    cat("Fitting engine: gam\n")
  }

Thanks!
Dave

@erex
Copy link
Member

erex commented Aug 29, 2023

No doubt you're right Dave; you can guess that bam hasn't received much use. Thanks for creating an issue and showing the file and line numbers that need attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants