Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dsm.var.gam when predicted values are 0 #39

Open
dill opened this issue May 15, 2020 · 2 comments
Open

dsm.var.gam when predicted values are 0 #39

dill opened this issue May 15, 2020 · 2 comments
Labels
Milestone

Comments

@dill
Copy link
Contributor

dill commented May 15, 2020

If predictions are 0 (therefore on the linear predictor scale log(0)=-Inf), then getting derivatives for use in variance estimation is tricky. Numerically (grad()), it falls over.

This seems like it would be relatively rare (predictions of exact zeros seem unlikely due to the smooth nature of the model).

@dill dill added the bug label May 15, 2020
@dill dill self-assigned this Jan 12, 2021
@dill dill added this to the 2.4.0 milestone Sep 20, 2021
@dill dill modified the milestones: 2.4.0, dsm 2.3.4 Nov 3, 2022
@dill
Copy link
Contributor Author

dill commented Dec 5, 2022

This is a somewhat unlikely bug. It relies on a case where we have (numerically) zero predictions, which barely ever happens. It's actually pretty hard to reproduce.

@dill dill assigned dill and unassigned dill Dec 5, 2022
@dill
Copy link
Contributor Author

dill commented Dec 5, 2022

Throw a warning if there is a zero prediction?

@dill dill removed their assignment Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant