Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plus sampling simulations #18

Open
LHMarshall opened this issue Jun 29, 2021 · 1 comment
Open

Add plus sampling simulations #18

LHMarshall opened this issue Jun 29, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request low priority Low priority

Comments

@LHMarshall
Copy link
Member

Currently, simulations can only handle minus sampling designs.
This needs expanded to include plus sampling, this will help test edge effects.

@LHMarshall LHMarshall added the enhancement New feature or request label Jun 29, 2021
@LHMarshall LHMarshall self-assigned this Jun 29, 2021
@LHMarshall LHMarshall added this to the Release 1.0.0 milestone Jul 15, 2021
@erex
Copy link
Member

erex commented Jul 25, 2021

I believe dsims will perform minus sampling, but will give the wrong result, is that correct? I compared two simulations from the example provided in make.simulation help; one using minus sampling, and one using plus sampling:

plus.design <- make.design(region = region,
                      transect.type = "line",
                      edge.protocol= "plus",
                      design = "systematic",
                      samplers = 20,
                      design.angle = 0,
                      truncation = 50)
minus.design <- make.design(region = region,
                           transect.type = "line",
                           edge.protocol= "minus",
                           design = "systematic",
                           samplers = 20,
                           design.angle = 0,
                           truncation = 50)

The results suggests simulation in the presence of plus sampling might be doing the wrong thing, is that accurate?

minus.bias <- summary(minus.simulation.result)@individuals$D$percent.bias
print(minus.bias)
[1] 0.8600559
plus.bias <- summary(plus.simulation.result)@individuals$D$percent.bias
print(plus.bias)
[1] -20.04955

As an interim measure, could dsims generate an error or warning when make.simulation detects use of a design object that invokes plus sampling, rather than letting the user conduct a simulation producing an incorrect result?

@LHMarshall LHMarshall added the low priority Low priority label Mar 23, 2022
@LHMarshall LHMarshall removed this from the CRAN Release 1.0.0 milestone Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority Low priority
Projects
None yet
Development

No branches or pull requests

2 participants