Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't trigger canned responses for bots #1660

Open
2 of 3 tasks
Robelo06 opened this issue Apr 4, 2024 · 1 comment
Open
2 of 3 tasks

Don't trigger canned responses for bots #1660

Robelo06 opened this issue Apr 4, 2024 · 1 comment

Comments

@Robelo06
Copy link

Robelo06 commented Apr 4, 2024

Expected behavior

The bot should not reply to other bots messages, such as !ip sent by a bot when DiscordChatChannelBlockBots is true

Actual behavior

The Bot does reply to other bots messages
image
image

Steps to reproduce

Install the latest DiscordSRV Version
Change the config.yml option DiscordChatChannelBlockBots and set it to true
Start the server and make a bot say !ip as a response

Server software and version

git-Paper-464 (MC: 1.20.4)

Checks

  • I am not using an outdated version of DiscordSRV.
  • I asked in DiscordSRV's Discord server to see whether this issue is in fact a bug that needs to be fixed.
  • I didn't actually check any of these things

Anything else

DEBUGGER: https://bin.scarsz.me/f91c1280-f3a4-46bc-bbf5-f50a0fc3e78b#7XsCs7XMGkJTyzoCgOfuvBbMYFEiJsxa

@Robelo06 Robelo06 added the bug label Apr 4, 2024
@Dinty1 Dinty1 changed the title DiscordChatChannelBlockBots doesn't block bots DiscordChatChannelBlockBots doesn't block bots in canned responses Apr 4, 2024
@Vankka
Copy link
Member

Vankka commented Apr 6, 2024

That is not what that option does,

# DiscordChatChannelBlockBots: whether bots should be blocked from Discord -> MC chat

But DiscordSRV shouldn't trigger canned responses for bots at all to begin with

@Vankka Vankka changed the title DiscordChatChannelBlockBots doesn't block bots in canned responses Don't trigger canned responses for bots Apr 6, 2024
@Vankka Vankka added enhancement and removed bug labels Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants